From 63747ac6534e3092f703527ba809eb93034bd57b Mon Sep 17 00:00:00 2001 From: Kent Overstreet <kent.overstreet@linux.dev> Date: Tue, 22 Aug 2023 15:45:35 -0400 Subject: [PATCH] Fix null ptr deref in bbpos_parse() Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev> --- tools-util.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools-util.c b/tools-util.c index 624656a1..81ce63ae 100644 --- a/tools-util.c +++ b/tools-util.c @@ -671,6 +671,10 @@ struct bbpos bbpos_parse(char *buf) die("invalid bbpos %s", buf); ret.btree = read_string_list_or_die(field, bch2_btree_ids, "btree id"); + + if (!s) + die("invalid bbpos %s", buf); + ret.pos = bpos_parse(s); return ret; }