alex/bcachefs-tools
1
0
Fork 0
mirror of https://github.com/koverstreet/bcachefs-tools.git synced 2025-02-23 00:00:02 +03:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

mount: print a helpful error message

Browse Source 
Just returning a failure exit status makes it hard to tell what the
actual issue was. Instead, the mount command now also provides some
textual output.

See https://github.com/koverstreet/bcachefs-tools/issues/308 for an
example where mount does not provide any helpful output, even with
BCACHEFS_LOG=trace enabled.

Signed-off-by: Florian Schmaus <flo@geekplace.eu>
This commit is contained in:
Florian Schmaus 2024-10-25 10:44:21 +02:00
parent 4f9293b045
commit 9ed0f3fd72
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/commands/mount.rs
View File

@ -10,7 +10,7 @@ use std::{
use anyhow::{ensure, Result}; use anyhow::{ensure, Result};
use bch_bindgen::{bcachefs, bcachefs::bch_sb_handle, opt_set, path_to_cstr}; use bch_bindgen::{bcachefs, bcachefs::bch_sb_handle, opt_set, path_to_cstr};
use clap::Parser; use clap::Parser;
use log::{debug, info}; use log::{debug, error, info};
use uuid::Uuid; use uuid::Uuid;
use crate::{ use crate::{
@ -385,6 +385,9 @@ pub fn mount(mut argv: Vec<String>, symlink_cmd: Option<&str>) -> std::process::
match cmd_mount_inner(&cli) { match cmd_mount_inner(&cli) {
Ok(_) => std::process::ExitCode::SUCCESS, Ok(_) => std::process::ExitCode::SUCCESS,
Err(_) => std::process::ExitCode::FAILURE, Err(e) => {
error!("Mount failed: {e}");
std::process::ExitCode::FAILURE
}
} }
} }