From dd2c7b9b891ae8ea39997d2053b9951a6ecbbb29 Mon Sep 17 00:00:00 2001 From: Kent Overstreet Date: Fri, 18 Apr 2025 17:24:19 -0400 Subject: [PATCH] format: Ensure we pick power of two bucket size Non power of two bucket sizes are allowed - but not preferred. We were accidentally picking bucket sizes that weren't blocksize aligned - ouch. Signed-off-by: Kent Overstreet --- c_src/libbcachefs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/c_src/libbcachefs.c b/c_src/libbcachefs.c index a0b1d0b7..2abf488d 100644 --- a/c_src/libbcachefs.c +++ b/c_src/libbcachefs.c @@ -112,6 +112,8 @@ u64 bch2_pick_bucket_size(struct bch_opts opts, dev_opts_list devs) /* We also prefer larger buckets for performance, up to 2MB at 2T */ bucket_size = max(bucket_size, perf_lower_bound); + bucket_size = roundup_pow_of_two(bucket_size); + return bucket_size; }