alex/bcachefs-tools
1
0
Fork 0
mirror of https://github.com/koverstreet/bcachefs-tools.git synced 2025-03-10 00:00:04 +03:00
Code Issues Actions Packages Projects Releases Wiki Activity

Cosmetic fixes for device resize-journal

Browse Source 
Correct the operation name from 'journal-resize' to 'resize-journal' in the
bcachefs usage summary, matching the command that is actually implemented.

Fix the size argument so it isn't optional. Defaulting to the entire device
makes sense for 'device resize', to automatically expand the fs to fill the
block device. However, it is never meaningful (or possible) to expand the
journal to the full disk.

Signed-off-by: Chris Webb <chris@arachsys.com>
This commit is contained in:
Chris Webb 2021-10-24 13:52:32 +01:00 committed by Kent Overstreet
parent 49923376d1
commit f5c0b67603
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
bcachefs.c
View File

@ -56,7 +56,7 @@ static void usage(void)
" device evacuate Migrate data off of a specific device\n" " device evacuate Migrate data off of a specific device\n"
" device set-state Mark a device as failed\n" " device set-state Mark a device as failed\n"
" device resize Resize filesystem on a device\n" " device resize Resize filesystem on a device\n"
" device journal-resize Resize journal on a device\n" " device resize-journal Resize journal on a device\n"
"\n" "\n"
"Commands for managing subvolumes and snapshots:\n" "Commands for managing subvolumes and snapshots:\n"
" subvolume create Create a new subvolume\n" " subvolume create Create a new subvolume\n"

4
cmd_device.c
View File

@ -539,7 +539,7 @@ int cmd_device_resize(int argc, char *argv[])
static void device_resize_journal_usage(void) static void device_resize_journal_usage(void)
{ {
puts("bcachefs device resize-journal \n" puts("bcachefs device resize-journal \n"
"Usage: bcachefs device resize-journal device [ size ]\n" "Usage: bcachefs device resize-journal device size\n"
"\n" "\n"
"Options:\n" "Options:\n"
" -h, --help display this help and exit\n" " -h, --help display this help and exit\n"
@ -571,7 +571,7 @@ int cmd_device_resize_journal(int argc, char *argv[])
char *size_arg = arg_pop(); char *size_arg = arg_pop();
if (!size_arg) if (!size_arg)
size = get_size(dev, dev_fd); die("Please supply a journal size");
else if (bch2_strtoull_h(size_arg, &size)) else if (bch2_strtoull_h(size_arg, &size))
die("invalid size"); die("invalid size");