Add print_g3_progress/print_g3_status methods for consistent status messages

This commit is contained in:
Dhanji R. Prasanna
2026-01-16 20:28:24 +05:30
parent 95f89d3f8e
commit 0e33465342
7 changed files with 123 additions and 21 deletions

View File

@@ -892,12 +892,14 @@ impl<W: UiWriter> Agent<W> {
// Check if we need to do 90% auto-compaction
if self.pending_90_compaction {
self.ui_writer
.print_context_status("\ng3: compacting session ...\n");
if let Err(e) = self.force_compact().await {
warn!("Failed to auto-compact at 90%: {}", e);
} else {
self.ui_writer.println("");
self.ui_writer.println("");
self.ui_writer.print_g3_progress("compacting session");
match self.force_compact().await {
Ok(true) => self.ui_writer.print_g3_status("compacting session", "done"),
Ok(false) => self.ui_writer.print_g3_status("compacting session", "failed"),
Err(e) => {
self.ui_writer.print_g3_status("compacting session", &format!("error: {}", e));
}
}
self.pending_90_compaction = false;
}
@@ -1071,12 +1073,11 @@ impl<W: UiWriter> Agent<W> {
self.ui_writer.print_context_thinning(&thin_summary);
if !self.context_window.should_compact() {
self.ui_writer
.print_context_status("g3: thinning resolved capacity issue\n");
self.ui_writer.print_g3_status("thinning", "resolved");
return Ok(false);
}
self.ui_writer
.print_context_status("g3: thinning insufficient, compacting ...\n");
self.ui_writer.print_g3_status("thinning", "insufficient");
self.ui_writer.print_g3_progress("compacting session");
}
// Compaction still needed
@@ -1086,10 +1087,10 @@ impl<W: UiWriter> Agent<W> {
use crate::compaction::{perform_compaction, CompactionConfig};
self.ui_writer.print_context_status(&format!(
"\ng3: compacting session ({}%) ...",
self.context_window.percentage_used() as u32
));
self.ui_writer.println("");
self.ui_writer.print_g3_progress(
&format!("compacting session ({}%)", self.context_window.percentage_used() as u32)
);
let provider_name = self.providers.get(None)?.name().to_string();
let latest_user_msg = request
@@ -1115,14 +1116,13 @@ impl<W: UiWriter> Agent<W> {
.await?;
if result.success {
self.ui_writer
.print_context_status("g3: compacting session ... done\n");
self.ui_writer.print_g3_status("compacting session", "done");
self.compaction_events.push(result.chars_saved);
request.messages = self.context_window.conversation_history.clone();
return Ok(true);
}
self.ui_writer.print_context_status("⚠️ Unable to compact context. Consider starting a new session if you continue to see errors.\n");
self.ui_writer.print_g3_status("compacting session", "failed");
Err(anyhow::anyhow!(
"Context window at capacity and compaction failed. Please start a new session."
))

View File

@@ -17,6 +17,16 @@ pub trait UiWriter: Send + Sync {
/// Print a context window status message
fn print_context_status(&self, message: &str);
/// Print a g3-style status message in progress
/// Format: "g3: <message> ..."
/// - "g3:" should be bold green
fn print_g3_progress(&self, message: &str);
/// Print a g3-style status message with completion status
/// Format: "g3: <message> ... [status]"
/// - "g3:" should be bold green, "failed"/"error" status should be red
fn print_g3_status(&self, message: &str, status: &str);
/// Print a context thinning success message with highlight and animation
fn print_context_thinning(&self, message: &str);
@@ -124,6 +134,8 @@ impl UiWriter for NullUiWriter {
fn print_inline(&self, _message: &str) {}
fn print_system_prompt(&self, _prompt: &str) {}
fn print_context_status(&self, _message: &str) {}
fn print_g3_progress(&self, _message: &str) {}
fn print_g3_status(&self, _message: &str, _status: &str) {}
fn print_context_thinning(&self, _message: &str) {}
fn print_tool_header(&self, _tool_name: &str, _tool_args: Option<&serde_json::Value>) {}
fn print_tool_arg(&self, _key: &str, _value: &str) {}

View File

@@ -52,6 +52,8 @@ impl UiWriter for MockUiWriter {
.unwrap()
.push(format!("STATUS: {}", message));
}
fn print_g3_progress(&self, _message: &str) {}
fn print_g3_status(&self, _message: &str, _status: &str) {}
fn print_context_thinning(&self, _message: &str) {}
fn print_tool_header(&self, _tool_name: &str, _tool_args: Option<&serde_json::Value>) {}
fn print_tool_arg(&self, _key: &str, _value: &str) {}