analysis: Update dependency graph for commits b6d2582..9443f933

Focused analysis on past 10 commits covering:
- New skills module in g3-core (parser, discovery, prompt, embedded, extraction)
- Research tool externalized to skills/research/ skill
- SkillsConfig added to g3-config
- SDLC pipeline state moved to .g3/sdlc/

Key findings:
- 4 crates changed, 29 files affected (8 added, 2 deleted, 19 modified)
- No dependency cycles detected
- Clean DAG structure in new skills module
- Cross-crate coupling via g3-core::skills and g3-config::SkillsConfig
- Compile-time coupling to skills/research/ via include_str!

Agent: euler
This commit is contained in:
Dhanji R. Prasanna
2026-02-05 14:02:44 +11:00
parent 9443f9333b
commit 38da6a56ef
6 changed files with 798 additions and 782 deletions

View File

@@ -1,83 +1,61 @@
# Strongly Connected Components (Cycles)
**Generated**: 2025-02-02
**Method**: Manual analysis of crate and file-level dependency graph
## Crate-Level Cycles
**None detected.**
The crate dependency graph is a DAG (directed acyclic graph). All crate dependencies flow downward:
```
g3-cli → g3-core → g3-providers
→ g3-config
→ g3-planner → g3-core (creates diamond, not cycle)
→ g3-providers
→ g3-config
→ g3-computer-control
→ g3-providers
g3-core → g3-execution
→ g3-computer-control
```
## File-Level Cycles Within Crates
### g3-core
**Potential cycle via lib.rs re-exports:**
Multiple modules import from `lib.rs` (for `ToolCall`, `Agent`, etc.), and `lib.rs` declares these modules. This is standard Rust module structure, not a problematic cycle.
```
lib.rs ←──mod──→ streaming_parser.rs (uses crate::ToolCall)
lib.rs ←──mod──→ context_window.rs (uses crate::ToolCall)
lib.rs ←──mod──→ acd.rs (uses crate::ToolCall)
lib.rs ←──mod──→ streaming.rs (uses crate::ToolCall)
lib.rs ←──mod──→ stats.rs (uses crate::CacheStats)
lib.rs ←──mod──→ retry.rs (uses crate::{Agent, DiscoveryOptions, TaskResult})
lib.rs ←──mod──→ feedback_extraction.rs (uses crate::{Agent, TaskResult})
```
This is the standard Rust pattern where `lib.rs` defines types and submodules import them via `crate::`. Not a problematic SCC.
### g3-cli
**No problematic cycles detected.**
Dependencies flow from high-level modules (interactive, agent_mode, accumulative) down to utilities (simple_output, g3_status, template).
### g3-providers
**No cycles detected.**
All provider implementations (anthropic, openai, gemini, databricks, embedded, mock) import from `lib.rs` only.
### g3-planner
**No cycles detected.**
`planner.rs` imports from `git.rs`, `history.rs`, `llm.rs`, `state.rs`. No reverse dependencies.
## Cross-Crate Diamonds (Not Cycles)
The following diamond patterns exist but are not cycles:
1. **g3-cli → g3-core → g3-config** and **g3-cli → g3-config**
2. **g3-cli → g3-planner → g3-core** and **g3-cli → g3-core**
3. **g3-cli → g3-planner → g3-providers** and **g3-cli → g3-providers**
These are valid DAG structures where multiple paths lead to the same dependency.
**Scope**: Changes in commits `b6d2582..9443f933` (10 commits)
## Summary
| Scope | Cycles Found | Severity |
|-------|--------------|----------|
| Crate-level | 0 | N/A |
| File-level (g3-core) | 0 problematic | N/A |
| File-level (g3-cli) | 0 | N/A |
| File-level (g3-providers) | 0 | N/A |
| File-level (g3-planner) | 0 | N/A |
| Metric | Count |
|--------|-------|
| SCCs with >1 node | 0 |
| Trivial SCCs (single node) | 29 |
The codebase has a clean acyclic dependency structure.
## Analysis
**No dependency cycles detected** in the changed files.
The skills module has a clean DAG structure:
```
mod.rs (root)
├── parser.rs (leaf - no internal deps)
│ ▲
│ │
├── discovery.rs ──┬──► parser.rs
│ └──► embedded.rs
├── prompt.rs ─────────► parser.rs
├── embedded.rs (leaf - no internal deps)
│ ▲
│ │
└── extraction.rs ─────► embedded.rs
```
## Crate-Level Cycles
No cycles at crate level. Dependency direction:
```
g3-cli ──► g3-core ──► g3-config
│ │
│ └──► g3-providers
│ └──► g3-execution
│ └──► g3-computer-control
└──► g3-config
└──► g3-providers
└──► g3-planner ──► g3-core (creates potential for cycle)
```
**Note**: `g3-planner` depends on `g3-core`, and `g3-cli` depends on both. This is not a cycle but creates a diamond dependency pattern.
## Verification Method
Cycles detected by analyzing `use` statements and `mod` declarations:
- `use super::*` → parent module
- `use crate::*` → crate root
- `mod name` → child module
- `use external_crate::*` → cross-crate
No bidirectional edges found within the changed file set.