alex/g3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix --safari flag being blocked by Chrome diagnostics

Browse Source 
When --safari was passed, Chrome diagnostics were still running because
--chrome-headless defaults to true. This caused the CLI to hang while
running diagnostics for a browser that wouldn't be used.

Now skip Chrome diagnostics when --safari is explicitly set.
This commit is contained in:
Dhanji R. Prasanna
2026-01-17 09:20:21 +05:30
parent e3967a9948
commit eb6268641f
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
crates/g3-cli/src/utils.rs
View File

@@ -112,7 +112,8 @@ pub fn load_config_with_cli_overrides(cli: &Cli) -> Result<Config> {
} }
// Apply chrome-headless flag override // Apply chrome-headless flag override
if cli.chrome_headless { // Only apply chrome-headless if safari is not explicitly set
if cli.chrome_headless && !cli.safari {
config.webdriver.enabled = true; config.webdriver.enabled = true;
config.webdriver.browser = g3_config::WebDriverBrowser::ChromeHeadless; config.webdriver.browser = g3_config::WebDriverBrowser::ChromeHeadless;