Kory Maincent 910c4788d6 ethtool: Fix wrong mod state in case of verbose and no_mask bitset ... A bitset without mask in a _SET request means we want exactly the bits in the bitset to be set. This works correctly for compact format but when verbose format is parsed, ethnl_update_bitset32_verbose() only sets the bits present in the request bitset but does not clear the rest. The commit 6699170376 ("ethtool: fix application of verbose no_mask bitset") fixes this issue by clearing the whole target bitmap before we start iterating. The solution proposed brought an issue with the behavior of the mod variable. As the bitset is always cleared the old value will always differ to the new value. Fix it by adding a new function to compare bitmaps and a temporary variable which save the state of the old bitmap. Fixes: 6699170376 ("ethtool: fix application of verbose no_mask bitset") Signed-off-by: Kory Maincent <kory.maincent@bootlin.com> Link: https://patch.msgid.link/20241202153358.1142095-1-kory.maincent@bootlin.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>		2024-12-04 18:54:43 -08:00
..
bitset.c
bitset.h
cabletest.c
channels.c
cmis_cdb.c
cmis_fw_update.c
cmis.h
coalesce.c
common.c
common.h
debug.c
eee.c
eeprom.c
features.c
fec.c
ioctl.c
linkinfo.c
linkmodes.c
linkstate.c
Makefile
mm.c
module_fw.h
module.c
netlink.c
netlink.h
pause.c
phc_vclocks.c
phy.c
plca.c
privflags.c
pse-pd.c
rings.c
rss.c
stats.c
strset.c
tsinfo.c
tunnels.c
wol.c