b2dd71f9f7
Build of intel-speed-select will fail if you run: $ LDFLAGS="-Wl,--as-needed" /usr/bin/make V=1 ... gcc -O2 -Wall -g -D_GNU_SOURCE -Iinclude -I/usr/include/libnl3 -Wl,--as-needed -lnl-genl-3 -lnl-3 intel-speed-select-in.o -o intel-speed-select /usr/bin/ld: intel-speed-select-in.o: in function `handle_event': (...)/linux/tools/power/x86/intel-speed-select/hfi-events.c:189: undefined reference to `nlmsg_hdr' ... In this case the problem is that order when linking matters when using the flag -Wl,--as-needed, symbols not used at that point are discarded. So since intel-speed-select-in.o comes after, at that point the libraries/symbols are already discarded and then missing/undefined references are reported. To fix this, make sure we specify LDFLAGS after the object file. Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> Signed-off-by: Herton R. Krzesinski <herton@redhat.com> Link: https://lore.kernel.org/r/20220404210525.725611-1-herton@redhat.com Signed-off-by: Hans de Goede <hdegoede@redhat.com>
61 lines
1.8 KiB
Makefile
61 lines
1.8 KiB
Makefile
# SPDX-License-Identifier: GPL-2.0
|
|
include ../../../scripts/Makefile.include
|
|
|
|
bindir ?= /usr/bin
|
|
|
|
ifeq ($(srctree),)
|
|
srctree := $(patsubst %/,%,$(dir $(CURDIR)))
|
|
srctree := $(patsubst %/,%,$(dir $(srctree)))
|
|
srctree := $(patsubst %/,%,$(dir $(srctree)))
|
|
srctree := $(patsubst %/,%,$(dir $(srctree)))
|
|
endif
|
|
|
|
# Do not use make's built-in rules
|
|
# (this improves performance and avoids hard-to-debug behaviour);
|
|
MAKEFLAGS += -r
|
|
override CFLAGS += -O2 -Wall -g -D_GNU_SOURCE -I$(OUTPUT)include -I/usr/include/libnl3
|
|
override LDFLAGS += -lnl-genl-3 -lnl-3
|
|
|
|
ALL_TARGETS := intel-speed-select
|
|
ALL_PROGRAMS := $(patsubst %,$(OUTPUT)%,$(ALL_TARGETS))
|
|
|
|
all: $(ALL_PROGRAMS)
|
|
|
|
export srctree OUTPUT CC LD CFLAGS
|
|
include $(srctree)/tools/build/Makefile.include
|
|
|
|
#
|
|
# We need the following to be outside of kernel tree
|
|
#
|
|
$(OUTPUT)include/linux/isst_if.h: ../../../../include/uapi/linux/isst_if.h
|
|
mkdir -p $(OUTPUT)include/linux 2>&1 || true
|
|
ln -sf $(CURDIR)/../../../../include/uapi/linux/isst_if.h $@
|
|
|
|
$(OUTPUT)include/linux/thermal.h: ../../../../include/uapi/linux/thermal.h
|
|
mkdir -p $(OUTPUT)include/linux 2>&1 || true
|
|
ln -sf $(CURDIR)/../../../../include/uapi/linux/thermal.h $@
|
|
|
|
prepare: $(OUTPUT)include/linux/isst_if.h $(OUTPUT)include/linux/thermal.h
|
|
|
|
ISST_IN := $(OUTPUT)intel-speed-select-in.o
|
|
|
|
$(ISST_IN): prepare FORCE
|
|
$(Q)$(MAKE) $(build)=intel-speed-select
|
|
$(OUTPUT)intel-speed-select: $(ISST_IN)
|
|
$(QUIET_LINK)$(CC) $(CFLAGS) $< $(LDFLAGS) -o $@
|
|
|
|
clean:
|
|
rm -f $(ALL_PROGRAMS)
|
|
rm -rf $(OUTPUT)include/linux/isst_if.h
|
|
find $(or $(OUTPUT),.) -name '*.o' -delete -o -name '\.*.d' -delete
|
|
|
|
install: $(ALL_PROGRAMS)
|
|
install -d -m 755 $(DESTDIR)$(bindir); \
|
|
for program in $(ALL_PROGRAMS); do \
|
|
install $$program $(DESTDIR)$(bindir); \
|
|
done
|
|
|
|
FORCE:
|
|
|
|
.PHONY: all install clean FORCE prepare
|