fix(rocm): Address package review findings
CI / check (push) Has been cancelled

This commit is contained in:
2026-11-12 23:55:09 +03:00
parent 8630307624
commit f2abdc96f9
6 changed files with 28 additions and 26 deletions
+2 -2
View File
@@ -27,8 +27,8 @@ stdenv.mkDerivation (finalAttrs: {
hash = "sha256-Uv7/bM0zLc01hciLSdvY9fHJdpSYoOrgSK6WwyWHnWQ=";
};
# Upstream requires the ROCm 7.2.4 compiler for source builds, but supports
# running its release engine on ROCm 10. Keep the official gfx1151 code objects.
# Upstream built this release engine with ROCm 7.2.4 and tested it on ROCm 10.1.
# Keep the official gfx1151 code objects.
engine = fetchurl {
url = "https://github.com/jaedync/crucible-strix-halo/releases/download/v${finalAttrs.version}/crucible-engine-v${finalAttrs.version}-gfx1151-rocm7.2-linux-x86_64.gz";
hash = "sha256-U6P7SRFB86QgXQljvBQwTm8dNFHV5OrPEb/JkxX6Uzo=";
+4 -10
View File
@@ -33,16 +33,10 @@ let
tqdm
]
);
# The SDK compiler bypasses Nix's cc wrapper and needs explicit host paths.
hipHostFlags = lib.concatStringsSep " " [
"--gcc-toolchain=${stdenv.cc.cc}"
"-idirafter ${lib.getDev glibc}/include"
"-B${glibc}/lib"
"-L${glibc}/lib"
"-L${stdenv.cc.cc.lib}/lib"
"-Wl,-rpath,${glibc}/lib:${stdenv.cc.cc.lib}/lib"
"-Wl,--dynamic-linker=${stdenv.cc.bintools.dynamicLinker}"
];
hipHostFlags = import ../../_lib/therock-host-flags.nix {
inherit lib stdenv;
libc = glibc;
};
in
stdenv.mkDerivation (finalAttrs: {
pname = "strata";
+3 -10
View File
@@ -7,16 +7,9 @@
therockRocm,
}:
let
# TheRock's compiler bypasses the Nix cc wrapper.
hostFlags = lib.concatStringsSep " " [
"--gcc-toolchain=${stdenv.cc.cc}"
"-idirafter ${stdenv.cc.libc.dev}/include"
"-B${stdenv.cc.libc}/lib"
"-L${stdenv.cc.libc}/lib"
"-L${stdenv.cc.cc.lib}/lib"
"-Wl,-rpath,${stdenv.cc.libc}/lib:${stdenv.cc.cc.lib}/lib"
"-Wl,--dynamic-linker=${stdenv.cc.bintools.dynamicLinker}"
];
hostFlags = import ../../_lib/therock-host-flags.nix {
inherit lib stdenv;
};
programs = [
"strix_server"
"convert_qwen4exp"