36 lines
1.2 KiB
Diff
36 lines
1.2 KiB
Diff
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
||
|
|
From: Navid Emamdoost <navid.emamdoost@gmail.com>
|
||
|
|
Date: Wed, 25 Sep 2019 12:02:41 -0300
|
||
|
|
Subject: [PATCH] media: rc: prevent memory leak in cx23888_ir_probe
|
||
|
|
|
||
|
|
In cx23888_ir_probe if kfifo_alloc fails the allocated memory for state
|
||
|
|
should be released.
|
||
|
|
|
||
|
|
Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
|
||
|
|
Signed-off-by: Sean Young <sean@mess.org>
|
||
|
|
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
|
||
|
|
---
|
||
|
|
drivers/media/pci/cx23885/cx23888-ir.c | 5 ++++-
|
||
|
|
1 file changed, 4 insertions(+), 1 deletion(-)
|
||
|
|
|
||
|
|
diff --git a/drivers/media/pci/cx23885/cx23888-ir.c b/drivers/media/pci/cx23885/cx23888-ir.c
|
||
|
|
index e880afe37f15..d59ca3601785 100644
|
||
|
|
--- a/drivers/media/pci/cx23885/cx23888-ir.c
|
||
|
|
+++ b/drivers/media/pci/cx23885/cx23888-ir.c
|
||
|
|
@@ -1167,8 +1167,11 @@ int cx23888_ir_probe(struct cx23885_dev *dev)
|
||
|
|
return -ENOMEM;
|
||
|
|
|
||
|
|
spin_lock_init(&state->rx_kfifo_lock);
|
||
|
|
- if (kfifo_alloc(&state->rx_kfifo, CX23888_IR_RX_KFIFO_SIZE, GFP_KERNEL))
|
||
|
|
+ if (kfifo_alloc(&state->rx_kfifo, CX23888_IR_RX_KFIFO_SIZE,
|
||
|
|
+ GFP_KERNEL)) {
|
||
|
|
+ kfree(state);
|
||
|
|
return -ENOMEM;
|
||
|
|
+ }
|
||
|
|
|
||
|
|
state->dev = dev;
|
||
|
|
sd = &state->sd;
|
||
|
|
--
|
||
|
|
https://clearlinux.org
|
||
|
|
|