65 lines
1.7 KiB
Diff
65 lines
1.7 KiB
Diff
From 3289204eca4e4f1f873ceb5630f855b66373576e Mon Sep 17 00:00:00 2001
|
|
From: Hongbo Li <lihongbo22@huawei.com>
|
|
Date: Tue, 29 Oct 2024 20:54:08 +0800
|
|
Subject: [PATCH 054/233] bcachefs: use attribute define helper for sysfs
|
|
attribute
|
|
Content-Type: text/plain; charset="utf-8"
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
The sysfs attribute definition has been wrapped into macro:
|
|
rw_attribute, read_attribute and write_attribute, we can
|
|
use these helpers to uniform the attribute definition.
|
|
|
|
Signed-off-by: Hongbo Li <lihongbo22@huawei.com>
|
|
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
|
|
Signed-off-by: Alexander Miroshnichenko <alex@millerson.name>
|
|
---
|
|
fs/bcachefs/sysfs.c | 10 +++-------
|
|
1 file changed, 3 insertions(+), 7 deletions(-)
|
|
|
|
diff --git a/fs/bcachefs/sysfs.c b/fs/bcachefs/sysfs.c
|
|
index 47ac8d5ab562..97733c766948 100644
|
|
--- a/fs/bcachefs/sysfs.c
|
|
+++ b/fs/bcachefs/sysfs.c
|
|
@@ -211,6 +211,7 @@ BCH_PERSISTENT_COUNTERS()
|
|
#undef x
|
|
|
|
rw_attribute(discard);
|
|
+read_attribute(state);
|
|
rw_attribute(label);
|
|
|
|
read_attribute(copy_gc_wait);
|
|
@@ -235,11 +236,6 @@ write_attribute(perf_test);
|
|
BCH_TIME_STATS()
|
|
#undef x
|
|
|
|
-static struct attribute sysfs_state_rw = {
|
|
- .name = "state",
|
|
- .mode = 0444,
|
|
-};
|
|
-
|
|
static size_t bch2_btree_cache_size(struct bch_fs *c)
|
|
{
|
|
struct btree_cache *bc = &c->btree_cache;
|
|
@@ -774,7 +770,7 @@ SHOW(bch2_dev)
|
|
prt_char(out, '\n');
|
|
}
|
|
|
|
- if (attr == &sysfs_state_rw) {
|
|
+ if (attr == &sysfs_state) {
|
|
prt_string_option(out, bch2_member_states, ca->mi.state);
|
|
prt_char(out, '\n');
|
|
}
|
|
@@ -854,7 +850,7 @@ struct attribute *bch2_dev_files[] = {
|
|
|
|
/* settings: */
|
|
&sysfs_discard,
|
|
- &sysfs_state_rw,
|
|
+ &sysfs_state,
|
|
&sysfs_label,
|
|
|
|
&sysfs_has_data,
|
|
--
|
|
2.45.2
|
|
|